Version: 2.6.8.606

In the last method in this class :

        public static IEntityFactory2 GetEntityFactory(Type factoryType)
        {
            if(factoryType == null)
            {
                throw new ArgumentNullException("factory");
            }

            if(_factoryTypeLookup == null)
            {
                _factoryTypeLookup = new Dictionary<Type, IEntityFactory2>();
            }

            IEntityFactory2 result;
            if(!_factoryTypeLookup.TryGetValue(factoryType, out result))
            {
                result = (IEntityFactory2)Activator.CreateInstance(factoryType);
            }
            return result;
        }

Shouldn't it be adding the result to the Dictionary so that it doesn't have to create a factory each time as per the other methods in this class?

Quite possibly

I'll get the developers to take a look.

Matt

Good catch!

I'll add the code. I don't think that particular method is actually used inside the runtime (it's part of the fast serialization code)