Hi. I would like to ask if the adapter closes its internal db connection when an exception occurs and KeepConnectionOpen=true. In other words, is it safe for the the client to code like this:

DataAccessAdapter adp = new DataAccessAdapter(true);
adp.FetchEntity(..);
adp.FetchEntity(..);
adp.CloseConnection();

or is it expected to do the following to avoid connection leakage:

DataAccessAdapter adp = new DataAccessAdapter(true);
try {
  adp.FetchEntity(..);
  adp.FetchEntity(..);
}
finally { adp.CloseConnection(); }

The latter is the way to go. The DataAccessAdapter class does close/clean up at dispose, so eventually everything is cleaned up, you don't have control over when that will be (as the GC has to kick in), so cleaning up in a finally is the way to go

I see, that makes sense.

But I assume that in the case of KeepConnectionOpen=false, the adapter closes the connection before throwing the exception back to the caller, so try/finally is not required there. Is this correct?

obzekt wrote:

I see, that makes sense.

But I assume that in the case of KeepConnectionOpen=false, the adapter closes the connection before throwing the exception back to the caller, so try/finally is not required there. Is this correct?

True, if KeepConnectionOpen is false, every call to a method which will access the database will open a connection, use the connection and will close it. An exception internally will close the connection first.

A transaction always keeps a connection open.