We have just moved to Adapters and have seen that we should Dispose after using a Transaction...

Should I dispose after using a Transaction (what does it matter if I do not ?) --- This is probably more of a .net question ---

Should I dispose after using an Adapter (even if I do not use an explicit transaction)

Go ahead and just use this and it will take care of the disposal for you. I believe that disposing is not as necessary with MS SQL, moreso for firebird and oracle.

using (DataAccessAdapter adapter = new DataAccessAdapter()) { adapter.FetchCollection(myCollection, myFilter); // any other code that you use the adapter for }

This will automatically dispose the adapter for you when you are done, you do not need to worry about doing it after any transactions, since when you do it is longer usable.

Thanks - I thought that would be the case, but the doc stated Dispose should be called. Thought there must be a reason for this particularly with persisting changes...

PaulMckenzie wrote:

Thanks - I thought that would be the case, but the doc stated Dispose should be called. Thought there must be a reason for this particularly with persisting changes...

It's in the docs to encourage people to call Dispose in their code Better safe than sorry

So if possible, use the 'using' statement.