Hi,

Because of asp.net's db connection pooling I don't feel too anxious about opening and closing indepedent connections objects within multiple user controls on a single page.

Is a DataAdapter an expensive resource which needs to be shared around or can I create them when and where they're needed?

Cheers,

I.

Create when you need one, and dispose it right after that. Getting a connection from the pool is at most 20ms, and creating an object is even faster, and a dataadapter is actually just a datareader consumer. So you won't win much if you share such an object around

Also adapter is not threadsafe, right Frans?

Otis wrote:

Create when you need one, and dispose it right after that...

I've been wondering about this: why not just let the garbage collector dispose of the data adapter once it goes out of scope?

Jeff

I don't expect it to be threadsafe indeed, as it handles datareaders and connections internally.

I think disposing is a good thing in situations where you let the dataadapter open/close the connections.

Otis wrote:

I think disposing is a good thing in situations where you let the dataadapter open/close the connections.

Why?

As it then holds resources which should disposed themselves, e.g. the connection objects. They will eventually, when the dataadapter is cleaned up, but that can take a while.

Otis wrote:

As it then holds resources which should disposed themselves, e.g. the connection objects. They will eventually, when the dataadapter is cleaned up, but that can take a while.

Good. I haven't been disposing my dataadapters and I was concerned that I was permanently tying up resources. I'll go back and edit my code to manually dispose.

Thanks.

Jeff

It's not always a big deal though. It's not as if your code will crawl all of a sudden if you don't call Dispose, it's common practise to do so

If you're using C#, use the using(..) {} constuct, it will call Dispose for you

Otis wrote:

It's not always a big deal though. It's not as if your code will crawl all of a sudden if you don't call Dispose, it's common practise to do so

If you're using C#, use the using(..) {} constuct, it will call Dispose for you

Hey, I've been doing this all along... good to know I wasn't just hallucinating or wasting my time

Another reason not to share a single DataAccessAdapter is that transactions are bound to an adapter instance. From the docs:

"Because the transactional code is inside the DataAccessAdapter, every method of the DataAccessAdapter object you call after you've started a transaction is ran inside that transaction, including stored procedure calls, entity fetches, entity collection saves etc"

Jeff...

Btw I was talking about ADO.NET dataadapter objects, not DataAccessAdapter's.

DataAccessAdapter objects you always have to dispose if you're using Firebird. You can get away with not disposing them on other db's, but always close MANUALLY opened connections. Though if possible, call dispose, it's cleaner and it gets rid of dangling transactions as well

DataAccessAdapter is what I was originally referring to! Should've been more precise.